Fix/prerender hydration

[rschristian]

Hydration vs rendering is determined by whether script[type=isodata] can be found, however, #585 limited this to only existing when returning prerender data.

I attempted to pick through the slack as noted here , though I'm still not sure I haven't missed something that would indicate this is intentional, so let me know. This just seemed like the simplest solution to bring this up with.

If we don't want preact-iso to return isodata we'll probably need some other marker to decide whether to hydrate or not?

[changeset-bot]

🦋 Changeset detected

Latest commit: ac05e3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
preact-iso	Patch
wmr	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Size Change: 0 B

Total Size: 6.31 kB

ℹ️ View Unchanged

Filename	Size
packages/preact-iso/.dist/index.********.js	1.72 kB
packages/preact-iso/.dist/prerender.********.js	349 B
packages/preact-iso/hydrate.js	290 B
packages/preact-iso/index.js	195 B
packages/preact-iso/lazy.js	594 B
packages/preact-iso/prerender.js	629 B
packages/preact-iso/router.js	2.54 kB

_{compressed-size-action}

[rschristian]

There's a couple of flakey tests that seem to be taking turns on failing, reran the CI a few times now with no luck.

[developit]

Good catch, we never actually finished making this change.

The idea was that isodata should be specific to preact-iso (though there's not currently an API exposed for generating it). WMR should also inject data into a script if given result.data, but it needs to use a different name.

My preference:

• <script type="wmrdata"></script> gets appended to HTML by WMR if result.data is provided.
• preact-iso's prerender() appends <script type="isodata"></script> to the HTML it generates.
• preact-iso's hydrate() uses script[type="isodata"] to trigger hydration.

[rschristian]

That makes sense. Should be corrected now, assuming I'm not missing something.

CI gods finally graced me with a pass too.