xaxis / xhb adapter not working

[nikkoi]

Type of issue

We're having extensive problems getting the xaxis / xhb adapter working in prebid 1.x+ versions.

Description

Everything is working fine in versions prior to 1, but we haven't been able to get a single impressions through with the 1.x version, even though we've done a lot of debugging with the xaxis team.

Steps to reproduce

Use the xhb adapter with prebid 1.x+

Is there anyone that can confirm that it actually works for them. And if so, did you have any problems setting it up?

[nikkoi]

Here is an example, two bids are available, but it doesn't even attempt to set them as key values. How is this possible? @daniel-hoffmann thoughts?

[japedro]

@jsnellbaker - please could you confirm that the issue here is that a bid with zero cpm will be filtered out by targeting.getWinningBids even if there is a dealId present:

targeting.getWinningBids = function(adUnitCode, bidsReceived = getBidsReceived()) { const adUnitCodes = getAdUnitCodes(adUnitCode); return bidsReceived .filter(bid => includes(adUnitCodes, bid.adUnitCode)) .filter(bid => bid.cpm > 0) .map(bid => bid.adUnitCode) .filter(uniques) .map(adUnitCode => bidsReceived .filter(bid => bid.adUnitCode === adUnitCode ? bid : null) .reduce(getHighestCpm, getEmptyBid(adUnitCode)));

The intended behaviour is that a bid with zero cpm and a DealId should be included in targeting and this was the original idea behind the switch in auction.getBidsReceived:

// if there is any key value pairs to map do here var keyValues; if (bidObject.bidderCode && (bidObject.cpm > 0 || bidObject.dealId)) { keyValues = getKeyValueTargetingPairs(bidObject.bidderCode, bidObject); }

Is it possible to also include a similar OR at targeting.getWinningBids?

Thanks!

[nikkoi]

Yeah, we got this sorted using custom adserver targeting and always use bids. But if this is intended way of working, I would at least document it in the adapters .md file, that it doesn't work without specifying custom targeting.

[jsnellbaker]

This should be addressed in the next release (1.31.0) via the above PR.