ParrableIdSystem: cache request filter status in first-party cookie #7044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bid.js into PBID-96_requestFilterStatus
…-96_requestFilterStatus
…FilterStatus' into PBID-96_requestFilterStatus * origin/parrableIdSystem/PBID-96_requestFilterStatus: (63 commits) Smaato bid adapter: Rework multi imp support (prebid#6814) Adot Bid Adapter: add the advertising domains support (prebid#6876) Update Adtelligent, Adtarget, ViewDeos adapters to support adomain (prebid#6917) LockerDome Bid Adapter: support for meta.advertiserDomains (prebid#6921) Sublime Bid Adapter : Add support for meta.advertiserDomains (prebid#6920) Brightcom Bid Adapter: use getFloor function (prebid#6918) AdYouLike Bidder: Handle advertiser domains (prebid#6916) relaido Bid Adapter: Add meta OBJ to BidResponse (prebid#6914) Jixie Bid Adapter: add support for advertiserDomains (prebid#6898) Onomagic Bid Adapter: use getFloor function (prebid#6907) Sharethrough Bid Adapter: Use getFloor module for Prebid 5.0 compliance (prebid#6874) Accept outstream renderers defined in mediatype for PBS (prebid#6896) Yieldmo Bid Adapter: read video parameters from the ad unit (prebid#6873) smartx Bid Adapter: Add support for Floors Module (prebid#6902) add support for advertiser domains (prebid#6908) Onomagic Bid Adapter: handle meta.advertiserDomains (prebid#6906) Brightcom Bid Adapter: handle meta.advertiserDomains (prebid#6905) ucfunnel Bid Adapter: add support Price Floors Module (prebid#6806) eTarget Bid Adapter: add "getMetaData" function to adapter, support for advertiserDomains (prebid#6901) AdagioBidAdapter: support priceFloors module (prebid#6867) ...
Co-authored-by: Ian Flournoy <ian@parrable.com>
PBID-96: Store request-filter status in compound cookie
* master: (103 commits) Opt Out Bid Adapter: add new bid adapter (prebid#7029) Dependencies/Testing: update dependencies, npm audit fixes, and bump Browserstack versions (prebid#6828) 5.2.0-pre Prebid.js 5.1.0 IX Bid Adapter : reading video `placement` property (prebid#6994) changing PBS debug flag to boolean (prebid#7035) Ats analytics set sampling rate to 1 percent (prebid#7010) Update sspBC bid adapter (v5.0) (prebid#7002) Gamma Bid Adapter: support adomain for Prebid 5.0 (prebid#7033) Datablocks Bid Adapter : update bid adapter and add 5.0 compliance (prebid#6765) Add microadBidAdapter (prebid#7007) Adf Bid Adapter: add adform alias (prebid#7009) Fixed FPD issue after for Prebid.js 5.0 (prebid#7031) Zeta Ssp Bid Adapter: provide devicetype (prebid#7026) make sizes a variable as the code expects (prebid#7024) VidazooBidAdapter: support for response meta.advertiserDomains (v5.0) (prebid#7022) add uid2 to OpenX Bid Adapter (prebid#7015) Zeta Ssp Bid Adapter: page and domain fields from config (prebid#7019) tappx Bid Adapter: fix wrong requests with undefined params (prebid#7021) RealVu Analytics Adapter: remove "tablet" from device types (prebid#7016) ...
robertrmartinez
approved these changes
Jun 28, 2021
|
@robertrmartinez can you or someone else please merge this PR please? Thanks! |
prebidtappx
pushed a commit
to prebidtappx/Prebid.js
that referenced
this pull request
Nov 15, 2021
…rebid#7044) * Add tpcSupport, read it from xxhr and store it in compound cookie * Parse a cookie boolean number (0, 1) as a boolean value * Improve conditions * Add tests * Tests passing * Read the cookie splitting parrableId and params (tpc, tpcUntil) * Adapt tests * Revert linting in test task * Add request filter status handling * Improve date treatment * Replace Math.trunc with Math.floor * Run only parrable tests * Run all tests * Add tpcSupport, read it from xxhr and store it in compound cookie * Parse a cookie boolean number (0, 1) as a boolean value * Improve conditions * Add tests * Tests passing * Read the cookie splitting parrableId and params (tpc, tpcUntil) * Adapt tests * Revert linting in test task * Add request filter status handling * Improve date treatment * Replace Math.trunc with Math.floor * Run only parrable tests * Run all tests * Increase cookie TTL * Remove line break * Increase cookie expire time to 20s * Fix lint problems * Increase cookie time to 30s * Trigger CI run Co-authored-by: Ian Flournoy <ian@parrable.com> Co-authored-by: Victor <victorigualada@gmail.com> Co-authored-by: victorigualada <21220224+victorigualada@users.noreply.github.com> Co-authored-by: Ian Flournoy <ian@parrable.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
The Parrable backend supports arbitrary filters on requests. This change is about storing filter status and TTL in our first-party cookie in order to decrease the load on our backend systems.
After the TTL has elapsed, a request may be made to our backend. At this point, the request may or may not be filtered again.
This is an internal change only and does not affect the external API.
Other information
Author @victorigualada