Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3 not building due to non-public file #73

Closed
MattSich opened this issue May 25, 2018 · 5 comments
Closed

0.3 not building due to non-public file #73

MattSich opened this issue May 25, 2018 · 5 comments

Comments

@MattSich
Copy link

hi @ppuviarasu !

on 0.3 PBServerRequestBuilder.h was made public but it can't be found when pulling in the project as a pod. After a bit more digging, turns out that the imported pod project has PBServerRequestBuilder.h set to project scope.
I think since PBServerRequestBuilder.h is referencing PBAdUnit.h which was not changed from public to project, PBServerRequestBuilder.h can't be public and therefore is set to project when used with cocoapods.
Can we roll back the PBAdUnit.h access change and make it public again?

thanks

@ppuviarasu
Copy link
Collaborator

Hey Matt,

Thanks for bring this to our notice... we will work on this issue & provide updates soon.

Thanks

@shujew
Copy link

shujew commented May 30, 2018

@MattSich I fixed it temporarily by adding this to the end of my Podfile

post_install do |installer|
    installer.pods_project.targets.each do |target|
        # Fix for Prebid v0.3 missing header file issue
        for i in 0..target.headers_build_phase.files.length - 1
            build_file = target.headers_build_phase.files[i]
            if build_file.display_name == 'PBServerRequestBuilder.h'
                build_file.settings = { 'ATTRIBUTES' => ['Public']}
            end
        end
    end
end

@qkzhu
Copy link
Contributor

qkzhu commented Jul 17, 2018

Same issue here. Why not simply make PBServerRequestBuilder.h public or remove it from umbrella header file?

@shujew this will work, but it is no difference compare with manually change it to public. And if I want make PrebidMobile as my library dependency, each user use my library will have to use this fix, not good. Hope your can fix this soon.

@qkzhu
Copy link
Contributor

qkzhu commented Jul 17, 2018

This is not solved in 0.4 version.

I created a new Swift project, and in my pod file:

target 'PrebidTest' do
  use_frameworks!
  pod 'PrebidMobile'
end

And then import it in ViewController: import PrebidMobile and build. the error comes out.
For now, just select PBServerRequestBuilder.h, change Project to public under Target Membership

@ppuviarasu
Copy link
Collaborator

This is fixed in 0.5 version.

Please raise a issue if it still exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants