Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow over plate tutorial's Fluid cases differ #72

Closed
BenjaminRodenberg opened this issue Feb 19, 2020 · 2 comments
Closed

flow over plate tutorial's Fluid cases differ #72

BenjaminRodenberg opened this issue Feb 19, 2020 · 2 comments

Comments

@BenjaminRodenberg
Copy link
Member

This inconsistency leads to problems, if for the OF-FE case the user does not copy the Fluid folder from the OF-OF case (what we suggest in the documentation), but from the OF-Nutils case (which is available in the tutorials).

Can we improve this situation by using the same structure for all cases? From my point of view the participant names should be consistent. Running via Allrun vs. runFluid vs. manually is not very critical, but could by achieved by changing the Allrun script to call independent runFluid and runSolid scripts.

Another solution would be to provide an independent Fluid folder in the FE-FE case. This will avoid mistakes, but I like it that the copy-paste approach currently very explicitly illustrates the idea of reusing an existing solver.

@MakisH
Copy link
Member

MakisH commented Feb 19, 2020

This is (in my opinion) a duplicate of #28.

@BenjaminRodenberg
Copy link
Member Author

This is (in my opinion) a duplicate of #28.

100% correct. Then we should revive #28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants