-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FMU participants to oscillator tutorial #466
Conversation
Co-authored-by: Benjamin Uekermann <benjamin.uekermann@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried running this tutorial, but I faced some configuration issue, which should be easy to fix.
In terms of structure, it needs some changes to address #461, but this can happen in a follow-up.
The HTML variant is used in the CMakeLists.txt, maybe it is used by other tools
I can now run FMI2 and FMI3 with the newest version of FMpy 0.3.20 and also all plotting options. Ready to merge from my perspective. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can now also run and plot the results. Almost ready, I just thought we could remove a few potentially unused files and options (see comments).
Note that if I execute the left with FMI and right with Python, visualizing with
gives me this plot: If I execute the left with Python and right with FMI, visualizing with
gives me this plot: fmi-fmi gives me the same as python-python: I have not looked into the details, I am just raising this in case it looks strange. |
The different trajectories look like numerical features to me. Depends on which timestepping methods are used and combined. Playing around with WI, we should be able to remove the instability, but that's beyond this PR. |
v3-compatible replacement of #322
Using my own branch to have write access, instead of #465
Ready for review. Should work with the
main
branch of the FMI Runner (v0.2.0 will be released before merging here).Does still ignore #461. I would suggest to do the
oscillator
after merging here. Otherwise, things get complicated here.I ran the cases with the precompiled FMU, I did not try to recompile on any other system. @LeonardWilleke compiled the FMU.
The FMU cases give a higher error than the Python implementation (but converge for smaller time step sizes). We still don't understand why exactly IIRC, but this is consistent with the thesis and paper from @LeonardWilleke.