-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flow around controlled moving cylinder (coupling FMI with OpenFOAM) #474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some first comments on the general tutorial aspects (looks good already, needs some minor cleanup).
I have not yet tried to run it, and I don't have the expertise to review the FMI part.
flow-around-controlled-moving-cylinder/controller-fmi/PIDcontroller.fmu
Outdated
Show resolved
Hide resolved
flow-around-controlled-moving-cylinder/controller-fmi/fmu/PIDcontroller/FMI1CS.xml
Outdated
Show resolved
Hide resolved
flow-around-controlled-moving-cylinder/controller-fmi/fmu/PIDcontroller/config.h
Show resolved
Hide resolved
flow-around-controlled-moving-cylinder/controller-fmi/fmu/PIDcontroller/readme.html
Outdated
Show resolved
Hide resolved
flow-around-controlled-moving-cylinder/fluid-openfoam/constant/RASProperties
Outdated
Show resolved
Hide resolved
flow-around-controlled-moving-cylinder/fluid-openfoam/system/controlDict
Outdated
Show resolved
Hide resolved
flow-around-controlled-moving-cylinder/fluid-openfoam/system/decomposeParDict
Outdated
Show resolved
Hide resolved
flow-around-controlled-moving-cylinder/fluid-openfoam/system/fvSchemes
Outdated
Show resolved
Hide resolved
Update: I can run the case, even though it takes quite a while (I am already running for several minutes, and I am only at 10%). Is there anything we can do to speed it up, or just reduce the simulated time? edit: Takes around 70min to complete on my laptop. |
Writing in the README:
I already tweaked there a lot. The original case ran overnight. |
…ointDisplacement Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the few open questions that might need more documentation (but definitely need help from @LeonardWilleke), this looks ready from my perspective.
@uekerman feel free to merge once everything is clear.
I took the original case of @LeonardWilleke from https://doi.org/10.18419/darus-3549, ported it to v3, and made it "tutorials-ready" (shorter runtime, README, ...). We should make @LeonardWilleke a co-author when merging here.
I ran the case with the precompiled FMU, I did not try to recompile on any other system.