Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

‼️ Add own lttbc implementation #84

Closed
wants to merge 42 commits into from
Closed

‼️ Add own lttbc implementation #84

wants to merge 42 commits into from

Conversation

jonasvdd
Copy link
Member

@jonasvdd jonasvdd commented Jun 25, 2022

aim: Add own lttb implementation as this results in more (future) flexiblity

related: #65 #42 #32

todo:

  • compile scheme

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2022

Codecov Report

Merging #84 (1140166) into main (a2ca8cf) will decrease coverage by 0.18%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   98.12%   97.94%   -0.19%     
==========================================
  Files          10       10              
  Lines         745      777      +32     
==========================================
+ Hits          731      761      +30     
- Misses         14       16       +2     
Impacted Files Coverage Δ
...tly_resampler/aggregation/aggregation_interface.py 98.46% <ø> (-0.05%) ⬇️
...tly_resampler/figure_resampler/figure_resampler.py 89.18% <83.33%> (-0.82%) ⬇️
plotly_resampler/__init__.py 71.42% <100.00%> (ø)
plotly_resampler/aggregation/aggregators.py 98.41% <100.00%> (-0.16%) ⬇️
...ler/figure_resampler/figure_resampler_interface.py 99.71% <100.00%> (+0.01%) ⬆️
...sampler/figure_resampler/figurewidget_resampler.py 99.01% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2ca8cf...1140166. Read the comment docs.

@jvdd jvdd requested review from jvdd and emield12 and removed request for jvdd June 25, 2022 21:02
@jonasvdd jonasvdd mentioned this pull request Jun 28, 2022
pyproject.toml Outdated Show resolved Hide resolved
@jvdd
Copy link
Member

jvdd commented Jul 17, 2022

Closing this as #103 is now merged

@jvdd jvdd closed this Jul 17, 2022
@jonasvdd jonasvdd deleted the lttbv2 branch July 29, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants