Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Running jobs_runs_submit_and_wait_for_completion without run_name #31

Closed
ahuang11 opened this issue Sep 26, 2022 · 0 comments · Fixed by #32
Closed

Running jobs_runs_submit_and_wait_for_completion without run_name #31

ahuang11 opened this issue Sep 26, 2022 · 0 comments · Fixed by #32
Assignees
Labels
bug Something isn't working

Comments

@ahuang11
Copy link
Contributor

ahuang11 commented Sep 26, 2022

If run_name defaults to None, it will result in:

prefect.exceptions.ParameterTypeError: Flow run received invalid parameters:
 - run_name: none is not an allowed value

in jobs_runs_submit_and_wait_for_completion
    jobs_runs_state, jobs_runs_metadata = await jobs_runs_wait_for_completion(
ValueError: too many values to unpack (expected 2)

Because Prefect validates the input, but here the run_name arg isn't optional so it crashes:
https://github.com/PrefectHQ/prefect-databricks/blob/main/prefect_databricks/flows.py#L399-L400

Also need to update the type annotations in the base flow as well.

Originally reported from:
https://prefect-community.slack.com/archives/CL09KU1K7/p1664168414041899

@ahuang11 ahuang11 self-assigned this Sep 26, 2022
@ahuang11 ahuang11 added the bug Something isn't working label Sep 26, 2022
@ahuang11 ahuang11 mentioned this issue Sep 26, 2022
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant