Skip to content

Commit

Permalink
changelog / version
Browse files Browse the repository at this point in the history
  • Loading branch information
@hybridherbst
hybridherbst committed Sep 10, 2020
1 parent a4e144b commit ca9cebb
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
1 change: 1 addition & 0 deletions .gitignore
View file
Original file line number Diff line number Diff line change
Expand Up @@ -159,3 +159,4 @@ TestProjects/*/Temp/
.vscode/
TestProjects/*/*.sln
TestProjects/*/*.csproj
GLTFSerialization/.idea
6 changes: 6 additions & 0 deletions UnityGLTF/Assets/UnityGLTF/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this package will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [1.0.4-preview.8] - 2020-09-10
- built GLTFSerialization.dll against Newtonsoft.JSON 12.0.3
- removed Newtonsoft.JSON.dll from package
- added dependency on com.unity.nuget.newtonsoft-json@2.0.0
- added 2020.2 compatibility

## [1.0.4-preview.7] - 2020-07-24
- fix sRGB/linear conversion for normal maps depending on Unity color space

Expand Down
7 changes: 5 additions & 2 deletions UnityGLTF/Assets/UnityGLTF/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "com.pfc.org.khronos.unitygltf",
"displayName": "pfc Khronos GLTF Loader",
"version": "1.0.4-preview.7",
"version": "1.0.4-preview.8",
"unity": "2018.3",
"description": "Unity3D library for importing and exporting GLTF 2.0 assets. https://github.com/KhronosGroup/UnityGLTF",
"keywords": [
Expand All @@ -17,5 +17,8 @@
"description": "Various scenes showing GLTF functionality.",
"path": "Samples~"
}
]
],
"dependencies": {
"com.unity.nuget.newtonsoft-json": "2.0.0"
}
}

9 comments on commit ca9cebb

@Skylion007
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fork still require Linear Colorspaces or are Gamma Colorspaces supported too?

@hybridherbst
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on your render pipeline and type of materials you're using - linear vs. gamma is still an area that I have to finalize work on. I fixed a number of issues that were on the original though. If you find specific issues it would be great if you raise them here so I can address them directly.

@Skylion007
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hybridherbst I've just been looking around UnityGLTF's network to see what other users have patched: https://github.com/KhronosGroup/UnityGLTF/network Found a lot of potential patches in there and added KHR_extensions

@hybridherbst
Copy link
Author

@hybridherbst hybridherbst commented on ca9cebb Sep 22, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's quite sad that nobody seems to care for the main branch and PRs and people do a lot of redundant work. I stopped creating PRs for the time being since there's no reaction anyways.

I think the biggest improvements in this fork are

  • animation export support,
  • PBR export support,
  • supporting more texture export cases (e.g. render textures, wrap settings, tiling, ...)
  • a lot of battle testing in production, especially for export,
  • and proper structuring as a Unity UPM package.

@Skylion007
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hybridherbst In regards to particular issues that were never merged in. It might be nice to pull from these branches if you haven't fixed these issues already:

@Skylion007
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened a few PRs into the fork, although Github made it rather difficult. Had to modify the URL for opening the PR to get it to properly target the fork as the destination for the PR.

@hybridherbst
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I enabled Issues! Thanks to pointing me towards that :)

@Skylion007
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hybridherbst Please merge in the PRs when you get a chance. 👍

@hybridherbst
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try, but not sure when I'll get to it;
if you have the capability and want to accelerate this then feel free to try merging them in in your fork and do PRs with fixes if necessary.

Please sign in to comment.