please export delete function

[chengjianxi]

func (conn *Conn) delete(ctx context.Context, job *Job) error {
	ctx, span := trace.StartSpan(ctx, "github.com/prep/beanstalk/Conn.delete")
	defer span.End()

	_, _, err := conn.lcommand(ctx, "delete %d", job.ID)
	return err
}

[prep]

Hey JX, can you tell me the use-case in which you'd need it? Pretty much the entire API of this package returns a *beanstalk.Job{} on which you can call job.Delete(). Doesn't that suit your purpose?

[chengjianxi]

Yes, I insert a delayed message and delete it before it is consumed.
The usage scenario is: send a message to the client, then insert the delayed message to beanstalk. If the client ACK within a certain period of time (eg. 30 seconds), the message in beanstalk will be deleted, otherwise the message will be resent. Because messages are asynchronously, I think *beanstalk.Job{} is not fit.

[prep]

Hey JX, thanks for laying out your use-case 👍 I've exported the Delete() method on Conn{} and created a new release.

[chengjianxi]

Thank you !

[chengjianxi]

I think Producer's connection pool is great, so I put the Delete method in Producer.

#22

[prep]

Sorry for the late response, JX.

I don't think adding a Delete() method on Producer{} is such a good idea. Category-wise, Consumer{} would have been better, but it's really besides the point because both are "pools" of connections and you cannot just pick a random connection (as the code does) and perform a Delete() operation on it.

The reason for this is that your pool can refer to different beanstalk servers and each of them have their own count of job IDs. So deleting job 123 on a random server has a chance of either 1) not finding the job you were referring to, or worse 2) delete a different job than you intended.