-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch SP and memory offset to uint32 #1
Comments
Yes, fair point. I set out to mimic as much of the original |
sounds good. PS I'm starting a reference doc here and will continue tomorrow https://github.com/tetratelabs/wazero/pull/621/files just in case the notes help |
Very nice! I've pushed some changes including the change to |
thanks! |
There are some confusing code in the source wasm_exec.js which is about forcing unsigned numbers. The memory offset and stack pointer should both be uint32 not int32 where possible.
This is the correct way to force unsigned in go. The javascript does it via
sp >>>= 0;
which can be wholesale removed here as it has no effect, regardless of if the variable types are changed.golang/go@9848e93
The text was updated successfully, but these errors were encountered: