Define options once at startup

[mvanderkamp]

This also removes a couple of "getter" functions that were being used to look up options and fall back to their defaults.

I'm excited to see that this is starting to be actively maintained again! This is just a refactor suggestion so that the use of options in this plugin follows a more common idiom and such that options are easier to work with. (No need to recall the defaults every time you need to look one up).

[alerque]

Thanks for taking the time to contribute this!

Overall I like the direction and fully agree that defaults should be handled up front and everything set rather than checking/instantiating defaults deep in the code. That being said I have a couple concerns that should probably be considered before merging this:

The big one is what looks like a regression in functionality. The previous code stored all options in such a way that they could potentially be functions instead of just hard coded values. For example g:VimuxHeight might be an integer, but it might also be a function that returns 20% of the current split. Or g:VimuxRunnerType might be just a string "pane" or it might be a function that returns different runner types based on some discovery in the current file, project, environment, etc. I'm not sure if anybody uses that, but it was there and now it's not.

Along a similar vein, it looks like everything got moved to the g: global namespace where previously in a few cases it may have been possible to get buffer-local settings to stick if they were set at the right time. This may not have been utilized either because the way I think it could have been done is pretty convoluted, but before we introduce a regression like this lets make sure we have a way to set values in an non-global way. One example where this might matter, I have projects with code in several language. I'd like to configure my runners differently depending on what language the current bufffer is.

[mvanderkamp]

Along a similar vein, it looks like everything got moved to the g: global namespace where previously in a few cases it may have been possible to get buffer-local settings to stick if they were set at the right time. This may not have been utilized either because the way I think it could have been done is pretty convoluted, but before we introduce a regression like this lets make sure we have a way to set values in an non-global way. One example where this might matter, I have projects with code in several language. I'd like to configure my runners differently depending on what language the current bufffer is.

Okay I think I've got this supported easily now, just by looking up the b: dictionary first. The neat thing here is if we also convert VimuxLastCommand and VimuxRunnerIndex to use the b: dictionary you could have buffer-local runners! My thinking for how this would work is to set both b: and g: when setting these options. So if you've set it from the current buffer you get the current buffer's runner/command, and if you didn't, you get the most recently set runner/command.

[mvanderkamp]

Also let me know if you want this squashed / otherwise rebased down. The fixup commits are piling up...

[alerque]

I rebased this for you to get some style fixes I made on master and keep the indentation and whitespace consistent in the PR. I didn't change anything substantial other than style stuff.