Merge pull request #1412 from JacobEvelyn/filename-and-line

Sort text report output by file and line
presidentbeef · Oct 21, 2019 · 428bad2 · 428bad2
2 parents 9a9048d + c24049e
commit 428bad2
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/lib/brakeman/report/report_text.rb b/lib/brakeman/report/report_text.rb
@@ -19,7 +19,7 @@ def generate_report
     add_chunk generate_controllers if tracker.options[:debug] or tracker.options[:report_routes]
     add_chunk generate_templates if tracker.options[:debug]
     add_chunk generate_obsolete
-    add_chunk generate_errors 
+    add_chunk generate_errors
     add_chunk generate_warnings
   end
 
@@ -51,7 +51,7 @@ def generate_controllers
 
   def generate_header
     [
-      header("Brakeman Report"), 
+      header("Brakeman Report"),
       label("Application Path", tracker.app_path),
       label("Rails Version", rails_version),
       label("Brakeman Version", Brakeman::Version),
@@ -92,7 +92,7 @@ def generate_warnings
       HighLine.color("No warnings found", :bold, :green)
     else
       warnings = tracker.filtered_warnings.sort_by do |w|
-        [w.confidence, w.warning_type, w.fingerprint]
+        [w.confidence, w.warning_type, w.file, w.line, w.fingerprint]
       end.map do |w|
         output_warning w
       end
@@ -211,4 +211,3 @@ def render_array name, cols, values, locals
     double_space "Controller Overview", controllers
   end
 end
-