Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json_pure gem conflicts with json gem #164

Closed
matthauck opened this issue Oct 9, 2012 · 3 comments
Closed

json_pure gem conflicts with json gem #164

matthauck opened this issue Oct 9, 2012 · 3 comments

Comments

@matthauck
Copy link

Is there a reason why brakeman depends on "json_pure" gem instead of the more standard "json" gem? Currently brakeman is the only project in my gemfile that depends on json_pure instead of json, resulting in two conflicting classes being loaded into memory. I think I can work around it with some Gemfile trickery, but why not just depend on the JSON library and require "json/pure" to allow for greater compatibility?

@oreoshake
Copy link
Contributor

IIRC it was done so it doesn't depend on anything with C extensions, making it easier to deploy in some scenarios.

@matthauck
Copy link
Author

I think it would because I have other gems that depend on it and haven't ever noticed any conflicts

On Oct 9, 2012, at 2:41 PM, Neil Matatall notifications@github.com wrote:

IIRC it was done so it doesn't depend on anything with C extensions, making it easier to deploy in some scenarios. Does MultiJSON help out at all in this situation?


Reply to this email directly or view it on GitHub.

@presidentbeef
Copy link
Owner

I'm fine with using multi_json. I looked into it before and thought it didn't actually provide a JSON library, but I'm re-reading the docs now and I was mistaken.

presidentbeef added a commit that referenced this issue Oct 15, 2012
Repository owner locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants