Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abbrev warning for ruby 3.4.0 #1812

Closed
chaadow opened this issue Dec 25, 2023 · 4 comments · Fixed by #1825
Closed

abbrev warning for ruby 3.4.0 #1812

chaadow opened this issue Dec 25, 2023 · 4 comments · Fixed by #1825

Comments

@chaadow
Copy link
Contributor

chaadow commented Dec 25, 2023

Hi,

FYI:
after running brakeman with ruby 3.3.0 I have the following warning:
/Users/xx/.rbenv/versions/3.3.0/lib/ruby/gems/3.3.0/gems/brakeman-6.1.1/bundle/ruby/3.0.0/gems/highline-2.1.0/lib/highline.rb:17: warning: abbrev was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add abbrev to your Gemfile or gemspec. Also contact author of brakeman-6.1.1 to add abbrev into its gemspec.

@presidentbeef
Copy link
Owner

This actually a dependency of highline and was addressed in JEG2/highline#264. Hopefully there will be a new release of highline in the near future, since it's been a while.

@tisba
Copy link

tisba commented Jan 5, 2024

highline 3.0.0 was released which added abbrev as an explicit dependency, see https://github.com/JEG2/highline/blob/master/Changelog.md.

Don't quite understand how dependencies work with brakeman, should I just open a new issue to get this updated?

@tisba
Copy link

tisba commented Jan 8, 2024

Maybe it's easier if @presidentbeef would consider re-open this issue, as this can be fixed now by bumping the highline dependency.

@presidentbeef presidentbeef reopened this Jan 8, 2024
presidentbeef added a commit that referenced this issue Jan 15, 2024
@abinoam
Copy link

abinoam commented Jan 21, 2024

@zvkemp issued a PR for completely removing abbrev as it was not being used anymore.

JEG2/highline#268

Released already as 3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants