Even quieter #963

Closed
printercu opened this Issue Nov 15, 2016 · 7 comments

Projects

None yet

2 participants

@printercu

Hi!

I want to integrate brakeman into git hook, and think it would be great if it printed as less as possible (without header and list of checks, maybe even No warnings! when everything is OK). WDYT about this feature?

I have a look at code and see that there is a batch of reporters, and each one must be edited to support this option. Or maybe allow this option only for table-reporter?

@presidentbeef
Owner

Are you saying you want no output if no warnings are found (or just no warnings found) but you do want a report if warnings are found?

@printercu

Ah, I got that I can define my own report, made from Table. Just leave this lines. Do you want to have this reporter in the repo?

@presidentbeef
Owner

I don't think it would need to be a different report. Perhaps just an option like --no-header? Or --no-summary?

@printercu

This would be just enough. Do you think it would affect only table reporter? Other way there will be much more work to be done.

@presidentbeef
Owner

I'd do it for table and plain. The tricky thing with --no-summary is that the summary_only option becomes ternary instead of binary: true, false, and not set. But I think I like it best since it doesn't really add a new command line option.

@presidentbeef presidentbeef added a commit that referenced this issue Dec 16, 2016
@presidentbeef Add option to hide summary in plain/table reports
with --no-summary

Closes #963
b3d1f91
@printercu

Cool, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment