Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax slim dependency for Slim 2.0.0 #353

Merged
merged 1 commit into from
Jun 24, 2013
Merged

Conversation

iwz
Copy link
Contributor

@iwz iwz commented Jun 24, 2013

Currently, if a project is using Slim 2.0.0, bundle update brakeman will not update to brakeman 2.0 because it's locked to 1.3.x.

This adjusts that to match the haml dependency.

Thanks,
Ian.

@presidentbeef
Copy link
Owner

Hi Ian,

Looks like there are no problems using Slim 2.0 that I can see, but I would rather the dependency be <3.0. The Haml dependency is <5.0 because Haml 4.0 exists :) This forces me to at least test when the major version changes.

@iwz
Copy link
Contributor Author

iwz commented Jun 24, 2013

Good call! I've updated the pull request.

Ian.

presidentbeef added a commit that referenced this pull request Jun 24, 2013
Relax slim dependency for Slim 2.0.0
@presidentbeef presidentbeef merged commit 1f67394 into presidentbeef:master Jun 24, 2013
@presidentbeef
Copy link
Owner

Thanks!

Repository owner locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants