Fix get version gemfile regexp and add tests

[themetric]

This hopefully fixes #359 by matching both end of line characters \r\n and \n. Also added a fix for matching variable length version numbers like 1.2 instead of just ones of length three like 1.2.3.

Do we need to support formats like these?

haml (>= 3.0, < 5.0)
mime-types (>= 1.16)
ruby_parser (~> 3.1)

[presidentbeef]

Hi Paul,

We are only looking at Gemfile.lock, all versions should be exact.

This actually matches almost anything inside the parentheses:

1.9.3p392 :001 > name = "hi"
 => "hi"
1.9.3p392 :002 > r = /\s#{name} \((\w+.+)\)(?:\n|\r\n)/
 => /\shi \((\w+.+)\)(?:\n|\r\n)/
1.9.3p392 :003 > r.match(" hi (blah)\n")
 => #<MatchData " hi (blah)\n" 1:"blah">

It doesn't really matter though (in fact, the original regex isn't that great either, since it doesn't escape .).

Can you rebase this and squash the commits to make it a little cleaner? Feel free to use a new branch if that's easier.

Thanks!

[themetric]

Good catch, I just updated the expression to be a little more picky about that. I'll rebase and make everything more organized.... 😃

[themetric]

Just squashed it all together into a single commit, much cleaner, I like that! Should be ready to merge. One test failing test_basic_auth_with_password but not sure if it's related to the changes I made. Thanks for looking into it...

[presidentbeef]

That test failure is just because you need to update ruby_parser :)

Thanks!