Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip branches with `Rails.env.test?' #868

Merged
merged 3 commits into from
May 2, 2016

Conversation

presidentbeef
Copy link
Owner

closes #862

@grosser can you test and see if this does what you wanted?

@grosser
Copy link
Contributor

grosser commented Apr 30, 2016

tried adding a match all route as a test and it was a warning:

# config/routes.rb
  if Rails.env.test?
    match '/:controller/:action'
  end
High ... routes.rb near line 124 |

@presidentbeef
Copy link
Owner Author

Okay, thanks. The specific test case is helpful.

@presidentbeef
Copy link
Owner Author

Should work now.

@grosser
Copy link
Contributor

grosser commented May 2, 2016

confirmed working! :D

@presidentbeef presidentbeef merged commit 2fe7445 into master May 2, 2016
@presidentbeef
Copy link
Owner Author

Great, thank you for testing!

@presidentbeef presidentbeef deleted the skip_branches_with_rails_env_test branch July 22, 2016 19:49
Repository owner locked and limited conversation to collaborators Sep 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore code inside of 'if Rails.env.test?'
2 participants