Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XHTML method for fixing internal links does not handle absolute links #1347

Closed
4 tasks done
greatislander opened this issue Sep 12, 2018 · 0 comments
Closed
4 tasks done

XHTML method for fixing internal links does not handle absolute links #1347

greatislander opened this issue Sep 12, 2018 · 0 comments
Assignees
@dac514
Labels
bug
Milestone
5.5.2

Comments

@greatislander
Copy link
Contributor

Prerequisites

Description

From Slack:

It only works if the the urls look like:
<a href="/links/chapter/my-chapter/">
and not:
<a href="https://pressbooks.test/links/chapter/my-chapter/">

Steps to Reproduce

  1. Create absolute internal links.
  2. Export to XHMTL (or PDF).
  3. Test internal links.

Expected behavior: They link within the PDF.

Actual behavior: They direct the user to the webbook version.

System Information

Pressbooks: 5.6.0-dev
@greatislander greatislander added this to the 5.6.0 milestone Sep 12, 2018
dac514 added a commit that referenced this issue Sep 13, 2018
@dac514
Fix Internal Links for Xhtml and HTMLBook (fixes #1347)
3c30c2d
greatislander pushed a commit that referenced this issue Sep 20, 2018
Fix Internal Links for Xhtml and HTMLBook (fixes #1347) (#1353)
98cde41 
* Fix Internal Links for Xhtml and HTMLBook (fixes #1347)
@greatislander greatislander modified the milestones: 5.6.0, 5.5.2 Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dac514 dac514

Labels
bug
Projects
None yet
Milestone
5.5.2
Development

No branches or pull requests
2 participants
@greatislander @dac514