Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Templating engine for XHTML outputs #831

Closed
4 tasks done
greatislander opened this issue Jul 4, 2017 · 1 comment
Closed
4 tasks done

Templating engine for XHTML outputs #831

greatislander opened this issue Jul 4, 2017 · 1 comment
Labels
enhancement
Milestone
4.4

Comments

@greatislander
Copy link
Contributor

Prerequisites

Description

Using http://github.com/jenssegers/blade/ we can clean up our export routines according to a more manageable MVC-seperation paradigm. Then things like #830 will be way easier.

Steps to Reproduce

Not applicable.

System Information

Pressbooks: 4.0.0-dev
WordPress: 4.8.0
PHP: 7.1
@greatislander greatislander added this to the 4.2 milestone Jul 4, 2017
@greatislander greatislander self-assigned this Jul 4, 2017
@greatislander greatislander removed this from the 4.2 milestone Jul 4, 2017
@greatislander greatislander mentioned this issue Jul 4, 2017
Closed
4 tasks
@greatislander greatislander modified the milestone: 4.4 Sep 11, 2017
@greatislander greatislander removed their assignment Sep 18, 2017
greatislander pushed a commit that referenced this issue Oct 11, 2017
@dac514
Implement Blade for XHTML (#831) (#962)
db270a6 
* Add jessegers/blade (5.4) to composer dependencies
* Change from Pimple to Laravel Container
* Fake Laravel app() so we can use Blade @Inject directive, make cache dir.
* Blade XHTML
* Seperate tidy & prettify, make pretty HTML output
* Fix problem we were trying to solve in the first place.
* Make pretty optional (default off for performance reasons).
* Get Blade just once.
* Exclude XHTML templates from code coverage
* Lock doctrine/inflector to v1.1.0 for PHP 5.6 compatibility
@dac514 dac514 changed the title Templating engine for XHTML/HTML/EPUB outputs Templating engine for XHTML outputs Oct 11, 2017
@dac514
Copy link
Contributor

dac514 commented Oct 11, 2017

Done for XHTML. Wontfix for Epub201. Moving towards a more unified HTMLBook and Epub3 strategy. These will use Blade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.4
Development

No branches or pull requests
2 participants
@greatislander @dac514