New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templating engine for XHTML outputs #831

Closed
greatislander opened this Issue Jul 4, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@greatislander
Member

greatislander commented Jul 4, 2017

Prerequisites

Description

Using http://github.com/jenssegers/blade/ we can clean up our export routines according to a more manageable MVC-seperation paradigm. Then things like #830 will be way easier.

Steps to Reproduce

Not applicable.

System Information

Pressbooks: 4.0.0-dev
WordPress: 4.8.0
PHP: 7.1

@greatislander greatislander added this to the 4.2 milestone Jul 4, 2017

@greatislander greatislander self-assigned this Jul 4, 2017

@greatislander greatislander removed this from the 4.2 milestone Jul 4, 2017

@greatislander greatislander referenced this issue Jul 4, 2017

Closed

New HTML schema #830

4 of 4 tasks complete

@greatislander greatislander modified the milestone: 4.4 Sep 11, 2017

@greatislander greatislander removed their assignment Sep 18, 2017

greatislander added a commit that referenced this issue Oct 11, 2017

Implement Blade for XHTML (#831) (#962)
* Add jessegers/blade (5.4) to composer dependencies
* Change from Pimple to Laravel Container
* Fake Laravel app() so we can use Blade @Inject directive, make cache dir.
* Blade XHTML
* Seperate tidy & prettify, make pretty HTML output
* Fix problem we were trying to solve in the first place.
* Make pretty optional (default off for performance reasons).
* Get Blade just once.
* Exclude XHTML templates from code coverage
* Lock doctrine/inflector to v1.1.0 for PHP 5.6 compatibility

@connerbw connerbw changed the title from Templating engine for XHTML/HTML/EPUB outputs to Templating engine for XHTML outputs Oct 11, 2017

@connerbw

This comment has been minimized.

Show comment
Hide comment
@connerbw

connerbw Oct 11, 2017

Member

Done for XHTML. Wontfix for Epub201. Moving towards a more unified HTMLBook and Epub3 strategy. These will use Blade.

Member

connerbw commented Oct 11, 2017

Done for XHTML. Wontfix for Epub201. Moving towards a more unified HTMLBook and Epub3 strategy. These will use Blade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment