-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace print pdf icon #2267
Replace print pdf icon #2267
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2267 +/- ##
============================================
+ Coverage 68.40% 68.47% +0.07%
+ Complexity 4944 4928 -16
============================================
Files 132 131 -1
Lines 21363 21353 -10
============================================
+ Hits 14613 14622 +9
+ Misses 6750 6731 -19 |
@greatislander Is there a historical reason why we need to leave the small sizes of export icons SCSS pressbooks/assets/src/styles/export.scss Lines 96 to 198 in 86b921b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @SteelWagstaff
@SteelWagstaff Nope. It used to be that the exports were displayed in a grid, with the most recent of each format as large icons and then a more compact grid with smaller icons below. These can and should be removed. |
@fdalcin Just pushed a commit which removes the unused small sizes of file export icons. If it still looks good to you, please squash and merge at your convenience. |
This PR fixes #2264 and #2266
To test:
Note: I did not replace the 36 and 72 px versions of this image as they are not used anywhere in Pressbooks. The large size is explicitly specified for the export table, which is the only place these icons are currently used in Pressbooks:
pressbooks/inc/modules/export/class-table.php
Lines 414 to 416 in 86b921b