Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url with trailing cash are not being cached #30

Closed
wkhayrattee opened this issue May 18, 2020 · 8 comments
Closed

url with trailing cash are not being cached #30

wkhayrattee opened this issue May 18, 2020 · 8 comments

Comments

@wkhayrattee
Copy link

Hello,
let's take for example the url (article post) https://domain.com/hello-world

  1. for https://domain.com/hello-world, x-pj-cache-status: hit

  2. for https://domain.com/hello-world/, x-pj-cache-status: miss

why is that

@soulseekah
Copy link
Contributor

hello-world shouldn't even be a thing. WordPress has a canonical redirect to hello-world/, we would cache the redirect (only 5xx codes are not cached) immediately.
Otherwise we make no assumptions, we can't cache it under the same key as that's literally a different URI.

@wkhayrattee
Copy link
Author

ok.. thank you for this info.
Apart from the headers, how can I make sure the caching is working?

I have installed two instances, one with both the pj object cache and pj page cache
I can't see big difference compared with the instance without any cache..

@soulseekah
Copy link
Contributor

How are you measuring this difference, @7php?

@wkhayrattee
Copy link
Author

using developer tools from firefox

@soulseekah
Copy link
Contributor

And what are the results? Are you looking at TTFB?

@soulseekah
Copy link
Contributor

I think it's an issue with your setup in some way and not a bug with the plugin.

I invite you to hire me or any other Codeable professional to help you solve your speed issu sites https://app.codeable.io/tasks/new?preferredContractor=76831

Closing this issue for now. Thanks.

@wkhayrattee
Copy link
Author

That's fine, I can manage.
I was just asking for thoughts.

Though, thank you for the service, I'll keep that in mind

@wkhayrattee
Copy link
Author

@soulseekah I found the issue..
actually when I logged-in or add a product to cart, woocommerce generates a session.
and because the session cookie is there, the caching does not work..

if I flush the browser cache, then it works..

it makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants