-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clickhouse: getting a sql.ErrSkip at createVersionTable() #730
Comments
closing as this should be fixed upstream (see ClickHouse/clickhouse-go#733 ) |
We have tests for ClickHouse, I'm surprised you hit this case, unless there was some changes in the driver itself. We're a few minor versions behind. |
@mfridman not sure exactly how. I can tell you I'm using clickhouse/clickhouse-server:23.12.3.40 image |
Okay, that's good info. We're still testing against 22.9, so probably worth upgrading to see what's broken goose/internal/testing/testdb/clickhouse.go Lines 18 to 19 in 234a9d5
|
hey, y'all
I'm getting a
driver: skip fast-path; continue as if unimplemented
(seeErrSkip
here for details). It seemsBeginTX()
member is not implemented (see https://github.com/ClickHouse/clickhouse-go/blob/b576bdef50952f0f6b8a26e5e6f641ca549b71f1/clickhouse_std.go#L40 ).If I'm reading the sql/driver docs correctly, one can catch-and-ignore this error
I'm using 3.9.12 binary
The text was updated successfully, but these errors were encountered: