Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickhouse: getting a sql.ErrSkip at createVersionTable() #730

Closed
FelipeLema opened this issue Mar 25, 2024 · 4 comments · Fixed by ClickHouse/clickhouse-go#1255
Closed

Comments

@FelipeLema
Copy link

hey, y'all

I'm getting a driver: skip fast-path; continue as if unimplemented (see ErrSkip here for details). It seems BeginTX() member is not implemented (see https://github.com/ClickHouse/clickhouse-go/blob/b576bdef50952f0f6b8a26e5e6f641ca549b71f1/clickhouse_std.go#L40 ).

If I'm reading the sql/driver docs correctly, one can catch-and-ignore this error

I'm using 3.9.12 binary

@FelipeLema
Copy link
Author

closing as this should be fixed upstream (see ClickHouse/clickhouse-go#733 )

@mfridman
Copy link
Collaborator

We have tests for ClickHouse, I'm surprised you hit this case, unless there was some changes in the driver itself. We're a few minor versions behind.

@FelipeLema
Copy link
Author

@mfridman not sure exactly how. I can tell you I'm using clickhouse/clickhouse-server:23.12.3.40 image

@mfridman
Copy link
Collaborator

Okay, that's good info. We're still testing against 22.9, so probably worth upgrading to see what's broken

CLICKHOUSE_IMAGE = "clickhouse/clickhouse-server"
CLICKHOUSE_VERSION = "22.9-alpine"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants