Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update clickhouse-go package version #734

Closed

Conversation

FelipeLema
Copy link

xref #730

@FelipeLema FelipeLema marked this pull request as ready for review March 27, 2024 15:47
@mfridman
Copy link
Collaborator

mfridman commented Mar 28, 2024

Keep in mind, some of the drivers are pinned, because they pull in a higher version of Go than we would like to support

@mfridman
Copy link
Collaborator

mfridman commented Mar 28, 2024

The best solution here, is to probably split the CLI as a separate Go module from the core library

#664

@FelipeLema
Copy link
Author

my Go-fu is not that good... I'll look into solving the dependencies, but it may take a while

In the meantime, if anyone wants to upload the fix to this branch (or start a new PR), please go ahead and do so

@mfridman
Copy link
Collaborator

I updated the ClickHouse docker image to the latest stable version: 24-alpine, and the integration tests are passing.

--- PASS: TestClickhouseRemote (25.00s)
--- PASS: TestClickhouse (4.40s)

#753

Note, we cannot bump the module github.com/ClickHouse/clickhouse-go/v2 module (driver) since goose minimum go version is set to go1.20

module github.com/pressly/goose/v3

go 1.20

https://github.com/ClickHouse/clickhouse-go/blob/main/go.mod#L1

Going to close this issue, but if you have any troubles let us know.

@mfridman mfridman closed this Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants