Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new -engine option #530

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

iamluc
Copy link

@iamluc iamluc commented Jun 8, 2023

I use goose on a ClickHouse cluster.
Unfortunately, the migrations table is created with the MergeTree engine which is perfect for a single node instance, but causes issue on a replicated clusted which should use the ReplicatedMergeTree engine.

This PR adds a new -engine option to override the engine. The default value of the option is empty, as it depends of the dialect.

Note: I implemented the feature only for ClickHouse, but I guess it could be useful for other databases like MySQL

@mfridman
Copy link
Collaborator

Dropped a comment in #520 (comment)

It appears different folks want different engine implementations, so this warrants a bit of a discussion.

@iamluc
Copy link
Author

iamluc commented Jul 11, 2023

Dropped a comment in #520 (comment)

It appears different folks want different engine implementations, so this warrants a bit of a discussion.

Thanks @mfridman, I replied to the comment in the other PR.

@mfridman
Copy link
Collaborator

Dropped a comment in another PR, but it attempts to accomplish the same thing. Would love your feedback if supplying your own small implementation would suite your needs.

#520 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants