fix(clickhouse): Fix list query to order by timestamp #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfridman
commented
Nov 12, 2023
| @@ -34,6 +34,6 @@ func (c *Clickhouse) GetMigrationByVersion(tableName string) string { | |||
| } | |||
|
|
|||
| func (c *Clickhouse) ListMigrations(tableName string) string { | |||
| q := `SELECT version_id, is_applied FROM %s ORDER BY version_id DESC` | |||
| q := `SELECT version_id, is_applied FROM %s ORDER BY tstamp DESC` | |||
There was a problem hiding this comment.
Discussion https://github.com/pressly/goose/pull/520/files#r1196945088
Need to think about this one, since the default precision is 1 second?
The more I think about it, maybe the only correct ordering for down (out-of-order) migration is by version.
https://twitter.com/brandur/status/1661654624300851200
Voted 4,3,2,1 because I feel like even if out of order was applied on the way up, it'd be easy to forget that later, so it should go back to being predictable based on version, but not sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.