Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GoogleImageUrlDecorator.php #143

Closed
wants to merge 4 commits into from
Closed

Update GoogleImageUrlDecorator.php #143

wants to merge 4 commits into from

Conversation

Warxcell
Copy link
Contributor

@Warxcell Warxcell commented Aug 3, 2017

Bug fix - exception class is not found.

Bug fix - exception class is not found.
@yann-eugone
Copy link
Member

Testing matrix needs to be updated, I'll propose a fix, you will be asked to rebase after

* Updated Travis testing matrix

* Fixing Travis build

* Fixing Travis build

* Fixed risky tests

* Removed HHVM in favor of PHP 7.1

* Removed unecessary bundles in test app

* Adde security config to test app to avoid deprecations

* Do not get router.request_context service directly to avoid deprecations

* Fixed PhpUnit and Symfony4 deprecations
@yann-eugone
Copy link
Member

@Warxcell can you rebase your branch, so the tests can pass ?

@yann-eugone
Copy link
Member

@Warxcell I'm very sorry, but I think we have a problem with the changeset... It is not relevant at all...
Can you consider creating another branche and just do you change again in an other Pull Request ?

@Warxcell Warxcell closed this Aug 7, 2017
@yann-eugone
Copy link
Member

closed in favor of #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants