Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite documentation #158

Merged
merged 4 commits into from Feb 20, 2018

Conversation

@yann-eugone
Copy link
Member

yann-eugone commented Feb 13, 2018

see related issue #156

preview access : here

yann-eugone added 2 commits Feb 13, 2018
@alain-flaus

This comment has been minimized.

Copy link
Member

alain-flaus commented Feb 13, 2018

👍

Some returns :

  • On the page "Dumping the sitemap", section "Dumping a single section" in code exemple : missing an empty line after the "use".
  • On the page "Dumping the sitemap", section "Forcing the base url" in code exemple : the command line arguments may not be explicit enough.
@yann-eugone

This comment has been minimized.

Copy link
Member Author

yann-eugone commented Feb 13, 2018

@alain-flaus just pushed a new version of the documentation with fixes for these things (and more)

@yann-eugone

This comment has been minimized.

Copy link
Member Author

yann-eugone commented Feb 14, 2018

@BenoitLeveque @alain-flaus @J-Ben87 please review this PR and approve it if it's ok for you

I'll accept it at the end of the week if nothing move

@yann-eugone yann-eugone merged commit 16a2c0e into master Feb 20, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@yann-eugone yann-eugone referenced this pull request Jun 4, 2018
17 of 17 tasks complete
@yann-eugone yann-eugone deleted the rewrite-documentation branch Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.