Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite documentation #158

Merged
merged 4 commits into from
Feb 20, 2018
Merged

Rewrite documentation #158

merged 4 commits into from
Feb 20, 2018

Conversation

yann-eugone
Copy link
Member

@yann-eugone yann-eugone commented Feb 13, 2018

see related issue #156

preview access : here

@halundraN
Copy link
Member

halundraN commented Feb 13, 2018

👍

Some returns :

  • On the page "Dumping the sitemap", section "Dumping a single section" in code exemple : missing an empty line after the "use".
  • On the page "Dumping the sitemap", section "Forcing the base url" in code exemple : the command line arguments may not be explicit enough.

@yann-eugone
Copy link
Member Author

@alain-flaus just pushed a new version of the documentation with fixes for these things (and more)

@yann-eugone
Copy link
Member Author

@BenoitLeveque @alain-flaus @J-Ben87 please review this PR and approve it if it's ok for you

I'll accept it at the end of the week if nothing move

@yann-eugone yann-eugone merged commit 16a2c0e into master Feb 20, 2018
@yann-eugone yann-eugone mentioned this pull request Jun 4, 2018
17 tasks
@yann-eugone yann-eugone deleted the rewrite-documentation branch September 26, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants