We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isNative flag passed to SqlToRowExpressionTranslator from SqlFunctionUtils is hard coded to false https://github.com/vermapratyush/presto/blob/d5eed561c31e21cb0b6cfa5f94038d9d4f2b4b89/presto-main/src/main/java/com/facebook/presto/sql/relational/SqlFunctionUtils.java#L111 https://github.com/prestodb/presto/blob/d5eed561c31e21cb0b6cfa5f94038d9d4f2b4b89/presto-main/src/main/java/com/facebook/presto/sql/relational/SqlFunctionUtils.java#L111
Ideally, this should be derived from session value, hard coding this to false does not break any flow since we always disable inline sql function for native: https://github.com/prestodb/presto/blob/master/presto-native-execution/src/test/java/com/facebook/presto/nativeworker/NativeQueryRunnerUtils.java#L42
The text was updated successfully, but these errors were encountered:
For SqlFunctionUtils,
the solution would be to add the isNative flag to the connector session and pass it through when we create the connector session.
Sorry, something went wrong.
native_execution_enabled
mbasmanova
Successfully merging a pull request may close this issue.
isNative flag passed to SqlToRowExpressionTranslator from SqlFunctionUtils is hard coded to false https://github.com/vermapratyush/presto/blob/d5eed561c31e21cb0b6cfa5f94038d9d4f2b4b89/presto-main/src/main/java/com/facebook/presto/sql/relational/SqlFunctionUtils.java#L111
https://github.com/prestodb/presto/blob/d5eed561c31e21cb0b6cfa5f94038d9d4f2b4b89/presto-main/src/main/java/com/facebook/presto/sql/relational/SqlFunctionUtils.java#L111
Ideally, this should be derived from session value, hard coding this to false does not break any flow since we always disable inline sql function for native:
https://github.com/prestodb/presto/blob/master/presto-native-execution/src/test/java/com/facebook/presto/nativeworker/NativeQueryRunnerUtils.java#L42
The text was updated successfully, but these errors were encountered: