Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Native] Test AbstractTestNativeGeneralQueries.testFiltersAndProjections is failing often #21820

Open
majetideepak opened this issue Jan 30, 2024 · 5 comments
Assignees

Comments

@majetideepak
Copy link
Collaborator

[ERROR] TestPrestoNativeGeneralQueriesJSON>AbstractTestNativeGeneralQueries.testFiltersAndProjections:172->AbstractTestQueryFramework.assertQuery:147->AbstractTestQueryFramework.assertQuery:152 Execution of 'actual' query failed: SELECT * FROM lineitem WHERE linenumber_as_smallint > 5 AND linenumber_as_smallint < 2

@majetideepak
Copy link
Collaborator Author

The issue is that the worker node is crashing
https://app.circleci.com/pipelines/github/prestodb/presto/11913/workflows/01d4e25f-d1e3-4219-8648-eea3a50f08dd/jobs/45456

Caused by: java.lang.RuntimeException: Encountered too many errors talking to a worker node. The node may have crashed or be under too much load. This is probably a transient issue, so please retry your query in a few minutes. (http://127.0.0.1:1234/v1/task/20240130_005127_00305_7hv52.0.0.0.0/results/0/0 - 604 failures, failure duration 300.24s, total failed request time 300.23s)

@elharo
Copy link
Contributor

elharo commented Mar 6, 2024

saw tbhis one again today:

[INFO] Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 54.166 s - in com.facebook.presto.nativeworker.TestPrestoNativeAggregations
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestPrestoNativeGeneralQueriesThrift>AbstractTestNativeGeneralQueries.testFiltersAndProjections:208->AbstractTestQueryFramework.assertQuery:149->AbstractTestQueryFramework.assertQuery:154 Execution of 'actual' query failed: SELECT linenumber, orderkey, discount FROM lineitem WHERE discount > 0.2
[ERROR] TestPrestoNativeGeneralQueriesThrift>AbstractTestNativeGeneralQueries.testWidthBucket:932->AbstractTestQueryFramework.assertQuery:149->AbstractTestQueryFramework.assertQuery:154 Execution of 'actual' query failed: SELECT width_bucket(to_unixtime(cast(ds as timestamp)), array[1609487900.1, 1619740800.2, 1622419200.3]) FROM customer_bucketed

@rschlussel
Copy link
Contributor

I created a PR to disable these tests #22134 (leaving the issue open though, since we should fix them and re-enable)

@jaystarshot
Copy link
Member

+1 these tests fail 80% of the time and it takes 1 hr for each retry

@rschlussel
Copy link
Contributor

updating that I didn't end up disabling these tests in that pr since it would remove a lot of coverage, but I split them up into 6 tests to narrow down the issue, and so that disabling if need be could have a smaller blast radius.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 Unprioritized
Status: 🆕 Unprioritized
Development

No branches or pull requests

5 participants