blackhole: remove synchronization of tables in BlackHoleMetadata #3679
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synchronization (atomic remove and put into concurrent hash map of tables) is not needed, it does not guarantee that concurrent operations on metadata can be run safely (e.g. rename table with drop table). Simple approach of fixing that would be to try implement transaction-like metadata storage with using ConnectorSession.getStartTime() as transaction id (txid) Then session with higher txid would need to wait for all operations with lower txid to finish. Ticket: prestodb#3647 Test Plan: none Reviewers: losipiuk
kokosing
force-pushed
the
feature_bh-race-condition
branch
from
2437b6e
to
4913a2e
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blackhole: remove synchronization of tables in BlackHoleMetadata
Synchronization (atomic remove and put into concurrent hash map of
tables) is not needed, it does not guarantee that concurrent operations
on metadata can be run safely (e.g. rename table with drop table).
Simple approach of fixing that would be to try implement transaction-like
metadata storage with using ConnectorSession.getStartTime() as transaction id (txid)
Then session with higher txid would need to wait for all
operations with lower txid to finish.
Ticket: #3647
Test Plan: none