Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show reorder joins cost in EXPLAIN ANALYZE VERBOSE #2725

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Show reorder joins cost in EXPLAIN ANALYZE VERBOSE #2725

merged 2 commits into from
Mar 5, 2020

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented Feb 4, 2020

No description provided.

@sopel39 sopel39 requested a review from martint February 4, 2020 12:36
@cla-bot cla-bot bot added the cla-signed label Feb 4, 2020
martint
martint approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@martint martint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment. Also, I'd squash these commits, as they are all part of the same logical change.

presto-main/src/main/java/io/prestosql/cost/PlanNodeStatsAndCostSummary.java Outdated
Comment on lines 21 to 25
private double outputRowCount;
private double outputSizeInBytes;
private double cpuCost;
private double memoryCost;
private double networkCost;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final

@sopel39
Copy link
Member Author

sopel39 commented Mar 5, 2020

Just one minor comment. Also, I'd squash these commits, as they are all part of the same logical change.

squashed two last commits. The first one is very mechanical one, so I prefer to leave it outside of actual EXPLAIN change

@sopel39 sopel39 force-pushed the ks/cbo_explain_analyze branch 2 times, most recently from 0effff7 to 8524b2b Compare March 5, 2020 15:20
@sopel39 sopel39 merged commit 33f78b5 into trinodb:master Mar 5, 2020
@sopel39 sopel39 deleted the ks/cbo_explain_analyze branch March 5, 2020 15:20
@sopel39 sopel39 mentioned this pull request Mar 5, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martint martint martint approved these changes

Assignees

@martint martint

Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sopel39 @martint