Remove redundant remote exchanges due to missing unaliasing #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removes redundant remote exchange from |
sopel39
force-pushed
the
ks/unalias_fix
branch
from
5941903
to
7e4ce65
Compare
|
This also makes planning more deterministic as unaliasing after reorder joins behaved differently depending if there were more predicates (derived from table scan handle) that could be inferred. |
|
Benchmarks. One can see some overhead of join using dictionaries ( |
|
#2862 fixes most of the observed CPU perf penalty. |
findepi
approved these changes
Feb 20, 2020
presto-main/src/main/java/io/prestosql/sql/planner/optimizations/UnaliasSymbolReferences.java
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/sql/planner/optimizations/UnaliasSymbolReferences.java
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/sql/planner/optimizations/UnaliasSymbolReferences.java
Outdated
Show resolved
Hide resolved
Symbols used in equi conditions have same types always.
sopel39
force-pushed
the
ks/unalias_fix
branch
from
7e4ce65
to
02af10e
Compare
sopel39
force-pushed
the
ks/unalias_fix
branch
from
02af10e
to
6f9bf18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.