Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix displaying prepared query in UI #2871

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Fix displaying prepared query in UI #2871

merged 1 commit into from
Feb 26, 2020

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Feb 18, 2020

Fixes #2784

Screenshots:

Zrzut ekranu 2020-02-18 o 13 43 05
Zrzut ekranu 2020-02-18 o 13 43 22

@cla-bot cla-bot bot added the cla-signed label Feb 18, 2020
sopel39
sopel39 approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@sopel39 sopel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is prepared query box correctly hidden for non prepared statement?

@wendigo
Copy link
Contributor Author

wendigo commented Feb 19, 2020

@sopel39 it is hidden for non prepared statements. Also I've added syntax higlighting to prepared query as well (looks more consistent)

@sopel39
Copy link
Member

sopel39 commented Feb 20, 2020

please rebase

@wendigo wendigo force-pushed the issue_2784 branch 2 times, most recently from 303b75c to 005083a Compare February 20, 2020 14:44
@sopel39
Copy link
Member

sopel39 commented Feb 21, 2020

please rebase

findepi
findepi approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

@wendigo
Copy link
Contributor Author

wendigo commented Feb 24, 2020

@findepi done

@findepi findepi merged commit c7362ff into trinodb:master Feb 26, 2020
@findepi findepi added this to the 331 milestone Feb 26, 2020
@findepi findepi mentioned this pull request Feb 26, 2020
Closed
6 tasks
@wendigo wendigo deleted the issue_2784 branch March 9, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sopel39 sopel39 sopel39 approved these changes

@findepi findepi findepi approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
331
Development

Successfully merging this pull request may close these issues.

Prepared Query Field and Alignment should be like Query Field
3 participants
@wendigo @sopel39 @findepi