Push DistinctLimit into TableScan #5756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
approved these changes
Nov 2, 2020
...in/src/main/java/io/prestosql/sql/planner/iterative/rule/PushDistinctLimitIntoTableScan.java
Show resolved
Hide resolved
kokosing
reviewed
Nov 2, 2020
...in/src/main/java/io/prestosql/sql/planner/iterative/rule/PushDistinctLimitIntoTableScan.java
Outdated
Show resolved
Hide resolved
...in/src/main/java/io/prestosql/sql/planner/iterative/rule/PushDistinctLimitIntoTableScan.java
Show resolved
Hide resolved
...in/src/main/java/io/prestosql/sql/planner/iterative/rule/PushDistinctLimitIntoTableScan.java
Show resolved
Hide resolved
This way the test method is self-contained.
Previously the stats collection would be bound to the session outside of transaction, leading to "Not in a transaction" exceptions being logged. (The stats collection failures are suppressed by default.)
findepi
force-pushed
the
findepi/distinct-limit-aggregation
branch
from
67db2e3
to
889f2c1
Compare
kokosing
approved these changes
Nov 4, 2020
...main/src/main/java/io/prestosql/sql/planner/iterative/rule/PushAggregationIntoTableScan.java
Outdated
Show resolved
Hide resolved
...main/src/main/java/io/prestosql/sql/planner/iterative/rule/PushAggregationIntoTableScan.java
Show resolved
Hide resolved
...in/src/main/java/io/prestosql/sql/planner/iterative/rule/PushDistinctLimitIntoTableScan.java
Show resolved
Hide resolved
...rc/test/java/io/prestosql/sql/planner/iterative/rule/TestPushDistinctLimitIntoTableScan.java
Show resolved
Hide resolved
...rc/test/java/io/prestosql/sql/planner/iterative/rule/TestPushDistinctLimitIntoTableScan.java
Outdated
Show resolved
Hide resolved
| .withApplyAggregation( | ||
| (session, handle, aggregates, assignments, groupingSets) -> { | ||
| ApplyAggregation applyAggregation = testApplyAggregation.get(); | ||
| if (applyAggregation != null) { |
There was a problem hiding this comment.
require non null applyAggregation? To make sure it is always set in test.
There was a problem hiding this comment.
The test code ensures -- and must ensure that -- thru the way how assertions are written.
findepi
force-pushed
the
findepi/distinct-limit-aggregation
branch
from
889f2c1
to
636948e
Compare
losipiuk
reviewed
Nov 4, 2020
...rc/test/java/io/prestosql/sql/planner/iterative/rule/TestPushDistinctLimitIntoTableScan.java
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/distinct-limit-aggregation
branch
from
636948e
to
d20cdc9
Compare
|
AC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5522