Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tool to publish documentation of functions such as doctest. #383

Closed
gogo2464 opened this issue Aug 11, 2022 · 5 comments
Closed

Use tool to publish documentation of functions such as doctest. #383

gogo2464 opened this issue Aug 11, 2022 · 5 comments

Comments

@gogo2464
Copy link

Currently functions are documented with comments. I suggest to use doctstrings and to publish docs online. We could use a tool like doctest for python. I do not know what to use for assembly language.

@dannye
Copy link
Member

dannye commented Aug 11, 2022

This is not really appropriate for a project like this.

@dannye dannye closed this as completed Aug 11, 2022
@gogo2464
Copy link
Author

Ok. I understand.

@vulcandth
Copy link
Contributor

@gogo2464 Another bit of info for you. Since pokered is written in assembly, it uses routine's. True functions do not exist, as that comes from higher level programming languages.

@Rangi42
Copy link
Member

Rangi42 commented Aug 11, 2022

Public documentation for individual functions makes sense when those functions are part of a public API for a library. That's not the case here: you use and modify the entire disassembly project, and are free to edit or replace anything in it.

The wiki tutorials exist for documenting common upgrades to the project, and (at least in pokecrystal) there are docs for describing how high-level systems in the game work.

@gogo2464
Copy link
Author

Well I needed it for my blog : https://gogo2464.github.io/gogo-s-blog/from-0-to-buffer-overflow/episode-1-reverse-engineering-and-exploitation-of-pokemon-red-and-blue/ . In this blog I required to easily find routines names and arguments. Anyway I finished it alone with the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants