Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing semicolon #139

Closed
EternalCode opened this issue Dec 22, 2016 · 3 comments
Closed

missing semicolon #139

EternalCode opened this issue Dec 22, 2016 · 3 comments

Comments

@EternalCode
Copy link

https://github.com/pret/pokeruby/blob/master/charmap.txt

The semi colon is not contained. I believe this would be 036.

@ghost
Copy link

ghost commented Dec 22, 2016

It's not included because it's not in version 1.0 of the game. All of the additions from 1.1 need to be added.

@camthesaxman
Copy link
Contributor

This has been resolved. The repository builds versions 1.0, 1.1, and 1.2.

@ghost
Copy link

ghost commented Jul 22, 2017

@EternalCode seems to have been referring to the charmap.txt file. In revision 1, several characters were added from the European editions of the game. However, these characters remained unused in the English edition, so revisions 1 and 2 still build even though the new characters are missing from the charmap.txt file.

https://tcrf.net/Pok%C3%A9mon_Ruby_and_Sapphire/Regional_Differences#Font_Differences_2

It might be useful to add the characters to charmap.txt in case anyone wanted to use them in a modification to the game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants