-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use prettier from current workspace #29
Comments
ref #33 |
Makes sense I guess. As @CiGit laid out in #33 there could be a prioritization order a long the lines of.
As far as I can tell this is what is going on here https://github.com/Microsoft/vscode-eslint/blob/master/eslint-server/src/server.ts#L257 |
Hey any update on this one @esbenp? I was just bitten by this after updating to 0.18.0. |
Honestly, February is pretty booked with work, so wont have time until at the end. Any PRs are welcome though.. |
I'll certainly try to work on this in these upcoming days. |
Looking at https://github.com/Microsoft/vscode-eslint/blob/master/eslint-server/src/server.ts#L349 it seems they way they do it is to use |
|
Ah yeah I get what you mean now. Well, maybe there is nothing wrong with adding a path config and set it to |
Sorry if I was unclear.
Seems easy to implement but I find this weird as a user. I've been thinking to alternatives:
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Currently plugin uses internal dependency on prettier. I think it would be better to use prettier from current projects node_modules, if it exists.
The text was updated successfully, but these errors were encountered: