Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Prettier require resolution #39

Merged
merged 2 commits into from
Mar 17, 2017
Merged

Conversation

CiGit
Copy link
Member

@CiGit CiGit commented Feb 17, 2017

Will resolve prettier in the following order

  1. local resolution
  2. global resolution postponed
  3. package resolution

Progress:

  • require local
  • require packaged

Other:

  • Changelog
  • Readme

fixes #29

Currently I'm waiting for a response on how to implement global resolution. global resolution postponed

@CiGit
Copy link
Member Author

CiGit commented Feb 21, 2017

@esbenp What do you think about making an other PR with global resolution once how as been defined. Use this PR only for it's local resolution.

By local I mean resolve relatively to the file being processed. Not a workspace resolution.

@esbenp
Copy link
Contributor

esbenp commented Mar 12, 2017

Yes I think we should just get this one out there. Ignore the global thing for now.

@CiGit
Copy link
Member Author

CiGit commented Mar 12, 2017

👍 will update that in next hours.

@CiGit
Copy link
Member Author

CiGit commented Mar 12, 2017

I've not touched the Readme. I don't know if I should put something in it about those change.

Review please.

@esbenp esbenp merged commit 94293bc into prettier:master Mar 17, 2017
@esbenp
Copy link
Contributor

esbenp commented Mar 17, 2017

@yannuil
Copy link

yannuil commented Nov 17, 2017

Any plans on the global resolutions?

@CiGit
Copy link
Member Author

CiGit commented Nov 17, 2017

None. If this is something for you, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use prettier from current workspace
3 participants