Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dependencies #473

Merged
merged 9 commits into from
Jun 4, 2018
Merged

update dependencies #473

merged 9 commits into from
Jun 4, 2018

Conversation

mubaidr
Copy link
Contributor

@mubaidr mubaidr commented May 30, 2018

No description provided.

CiGit
CiGit requested changes Jun 1, 2018
View reviewed changes
package.json Outdated
"typescript": "^2.6.2",
"vscode": "^1.1.10"
"@types/mocha": "^5.2.0",
"@types/node": "^10.1.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VSCode runs on node 7.9.0

Copy link
Contributor Author

@mubaidr mubaidr Jun 1, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to check latest version in vscode?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Help -> About

Copy link
Contributor Author

@mubaidr mubaidr Jun 1, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Dumb me! 😿

package.json Outdated
"ignore": "^3.3.7",
"prettier": "1.12.1",
"ignore": "^3.3.8",
"prettier": "1.13.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update again 😄 and I suspect a new version soon.

@CiGit
Copy link
Member

CiGit commented Jun 1, 2018

What does this update bring, except prettier, I've not read any patch note / Changelog.

By the way could you add an entry to CHANGELOG.md ? A minor prettier bump deserves it ! with a link to their blog post.

@mubaidr
Copy link
Contributor Author

mubaidr commented Jun 1, 2018

All dependencies including prettier have been updated to latest (& compatible) version.

Updated change-log too. 👍

@azz
Copy link
Member

azz commented Jun 2, 2018

1.13.4 was pushed yesterday.

@azz
Copy link
Member

azz commented Jun 2, 2018

Missed the changelog :)

@mubaidr
Copy link
Contributor Author

mubaidr commented Jun 2, 2018 •
edited
Loading

Will update the change-log. 🔢

CiGit
CiGit reviewed Jun 2, 2018
View reviewed changes
CHANGELOG.md Outdated
@@ -6,134 +6,138 @@ All notable changes to the "prettier-vscode" extension will be documented in thi

## [Unreleased]

## [1.3.4]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It certainly won't be version 1.3.4

Let it under [unreleased], a script does the rest 😃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh.. did not knew it. Updating.

@CiGit CiGit merged commit 1949d47 into prettier:master Jun 4, 2018
@mubaidr mubaidr mentioned this pull request Jun 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CiGit CiGit CiGit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mubaidr @CiGit @azz