Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/ Don't inline pipeline operator with leading ownline comment #5015

Merged
merged 3 commits into from
Sep 1, 2018

Conversation

flxwu
Copy link

@flxwu flxwu commented Aug 24, 2018

Resolves #5009 .
The pipeline operator now doesn't get inlined with an leading ownLineComment, but is instead treated as any other binary expression. Thus, the pipeline operator gets moven above the ownLineComment.

I also added tests for all other binary expressions as well as a separate test for the pipeline operator binary expression as this can only be run with babylon.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

@j-f1 j-f1 requested a review from duailibe August 24, 2018 18:06
@flxwu flxwu changed the title Don't inline pipeline operator with leading ownline comment Bugfix/ Don't inline pipeline operator with leading ownline comment Aug 26, 2018
@flxwu
Copy link
Author

flxwu commented Sep 1, 2018

any update on this PR?

@j-f1 j-f1 removed the request for review from duailibe September 1, 2018 22:38
@j-f1 j-f1 merged commit e86f085 into prettier:master Sep 1, 2018
@j-f1
Copy link
Member

j-f1 commented Sep 1, 2018

Thanks for contributing!

@flxwu flxwu deleted the bugfix/pipeline-leading-ownlineComment branch September 1, 2018 22:39
@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants