New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/ Don't inline pipeline operator with leading ownline comment #5015

Merged
merged 3 commits into from Sep 1, 2018

Conversation

Projects
None yet
3 participants
@flxwu
Contributor

flxwu commented Aug 24, 2018

Resolves #5009 .
The pipeline operator now doesn't get inlined with an leading ownLineComment, but is instead treated as any other binary expression. Thus, the pipeline operator gets moven above the ownLineComment.

I also added tests for all other binary expressions as well as a separate test for the pipeline operator binary expression as this can only be run with babylon.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.
@j-f1

j-f1 approved these changes Aug 24, 2018

@j-f1 j-f1 requested a review from duailibe Aug 24, 2018

@ikatyang ikatyang referenced this pull request Aug 25, 2018

Merged

Bugfix/ Leave Dangle Comments in NewExpression #5017

2 of 3 tasks complete

@flxwu flxwu changed the title from Don't inline pipeline operator with leading ownline comment to Bugfix/ Don't inline pipeline operator with leading ownline comment Aug 26, 2018

@flxwu

This comment has been minimized.

Contributor

flxwu commented Sep 1, 2018

any update on this PR?

@j-f1 j-f1 removed the request for review from duailibe Sep 1, 2018

@j-f1 j-f1 merged commit e86f085 into prettier:master Sep 1, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 96.48% (+0%) compared to 58d34bb
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@j-f1

This comment has been minimized.

Member

j-f1 commented Sep 1, 2018

Thanks for contributing!

@flxwu flxwu deleted the flxwu:bugfix/pipeline-leading-ownlineComment branch Sep 1, 2018

@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment