Bugfix/ Don't inline pipeline operator with leading ownline comment#5015
Merged
j-f1 merged 3 commits intoprettier:masterfrom Sep 1, 2018
Merged
Conversation
j-f1
approved these changes
Aug 24, 2018
3 tasks
flxwu
changed the title
Author
|
any update on this PR? |
Member
|
Thanks for contributing! |
lock
bot
added
the
locked-due-to-inactivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5009 .
The pipeline operator now doesn't get inlined with an leading ownLineComment, but is instead treated as any other binary expression. Thus, the pipeline operator gets moven above the ownLineComment.
I also added tests for all other binary expressions as well as a separate test for the pipeline operator binary expression as this can only be run with babylon.
docs/directory)