Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/1.x: prettier plugins do not work when installed with pnpm #211

Closed
andykais opened this issue Sep 25, 2019 · 3 comments
Closed

release/1.x: prettier plugins do not work when installed with pnpm #211

andykais opened this issue Sep 25, 2019 · 3 comments

Comments

@andykais
Copy link

Do you want to request a feature or report a bug?

What is the current/expected behavior?
the prettier plugin prettier-plugin-svelte should work when installed on a project. It does work with npm, it does not work with pnpm. I suspect the same issue will occur with any prettier plugin. I can create a repro repo if it helps.

What version of vim-prettier are you using - (output of :PrettierVersion) ?
1.0.0-alpha

What version of prettier are you using - (output of :PrettierCliVersion) ?
1.18.2

What is your prettier executable path - (output of :PrettierCliPath) ?
/hom/andrew/Build/dev/andykais.github.io.sapper/node_modules/.bin/prettier

Did this work in previous versions of vim-prettier and/or prettier ?
it works when installing with npm.

works:

npm i -D prettier-plugin-svelte prettier

does not work:

pnpm i -D prettier-plugin-svelte prettier
@mitermayer
Copy link
Member

At this stage we don't currently support pnpm feel free to submit a PR to add support to it.

In the meantime will be closing this issue and may re-open this in the future if we get enough bandwidth to get into it and if pnpm become mainstream

@NicoCevallos
Copy link

@andykais you could use the plugin with --plugin=./node_modules/prettier-plugin-svelte in the CLI. I found that here: prettier/prettier#8056 (comment)
Maybe not the best idea, but it works

@andykais
Copy link
Author

thank you for the tip! Do you know how I can pass arbitrary args to the vim prettier plugin though? Funnily enough I was in need of this yesterday and just decided to keep a global npm and pnpm node_modules in tandem to support prettier plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants