-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for example repo or gist #1
Comments
I'm assuming you're referencing an Ionic 2/3 app. I was able to successfully implement this in an Ionic v1 app, but haven't implemented it in Ionic 2/3 yet. I do plan on doing that soon though. Also, this plugin is built for both version so I would imagine it would work. Try declaring 'cordova' in the head of the source file where you want to use the plugin. You might have to rename it to something else like 'cordova-video-call' throughout the plugin (ex. cordova-video-call.videoconversation.open...). You can just declare it with: or if you change the name: The I don't have an example just yet but when I finally get this working in my Ionic3 app I'll try to send some more info if you're still having trouble. Hopefully this is helpful for you. -Price |
Thanks for supplying the repo @PriceFallin ! I've been using my own improved implementation of opentok plugin for video chats for over a year now. Would you be able to supply a sample running app (ionic 1) I would love to do a performance/usability test for twilio vs opentok. Thanks again! |
I was able to successfully get up and running with the help of your repo. Thanks! |
Hi @smuaq, I don't have a demo set up that I can provide. For this you'll need to just build your own, although all you really should need is a simple button that would call the cordova function to start the video chat. Of course you would also need to either set up your own server to get a token/roomID or generate one from Twilio's video tool console. @jamesdeantv Glad you got it working! |
Great thanks! |
@jamesdeantv mind sharing your code? |
@WisaniShilumani I actually started working on an ionic3 app now with the plugin and was able to get it working with my new build. Here's some tips:
Hope this helps! |
@PriceFallin Thanks a million! That's super helpful. I managed with the typescript work, but later ran into problems with cordova 7. It didn't like the hyphens in the AndroidManifest.xml file during the build. The I replaced all hyphens with points, and it's working fine now. Thanks for the plugin, been struggling with video calling for over 3 months now! |
Glad to hear you got things sorted. |
Hi @WisaniShilumani, would you mind to share with me how you did the change on hyphens ? Thank you very much. |
@WisaniShilumani or @dzungcao, can you share the solution to the hyphens error? I have the plugin working with iOS and recently added the Android platform to my project. When trying to build, I receive:
Are you suggesting renaming the plugin? Uninstall, rename, & reinstall?
Thanks! |
@cavalryjim No need to uninstall. Replace hyphens with points at both platform and plugin level. I did a search & find and made the changes at both levels. I recently made a switch to WebRTC and don't have a record of the changes, sorry about that. |
Posting this only to help anyone experiencing the '-' hyphen issue...
|
Hi there Prince. I arrived from the thread twilio/twilio-video.js#85
First, thanks for supplying the repo. Could you possibly provide an example repo of the plugin in a basic ionic app setup using the twilio programmable video sdk. The latest version as of this issue is "twilio-video": "1.5.0" I've tried implementing the plugin, but Im having trouble registering it in a page. It isn't explicitly stated how to declare the plugin.
For example:
declare const TwilioVideoPlugin;
declare const VideoConversationPlugin;
declare const cordova.videoconversation;
declare const cordova-plugin-twilio-video;
import * as ? from ?;
You stated in the readme to
Get token And Call the API cordova.videoconversation.open( RoomName: string, Token: string);
So, do you mean to first request the token from the server and then run
cordova.videoconversation.connect( RoomName: string, Token: string)
I ask this because the latest twilio video api doesn't contain a method or global called open.
Even a single gist showing the plugin being declared and then called in the export class would suffice.
Thanks again.
The text was updated successfully, but these errors were encountered: