Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Component: Tabs #420

Open
abautist opened this issue Dec 4, 2018 · 2 comments
Open

New Component: Tabs #420

abautist opened this issue Dec 4, 2018 · 2 comments
Labels
new component Proposal for new component

Comments

@abautist
Copy link
Collaborator

abautist commented Dec 4, 2018

I built a generalized tabs component that is flexible enough to be shareable across the org. Would it be appropriate to add it as an optional package associated with the design system (similar to carousel, modal..)?

If this is a direction we'd be interested in going, I can create a PR to continue the discussion.

@BeniCheni
Copy link
Collaborator

+1 for building tab component to v2 packages/ workspace.

But does "bare-bones" mean no design at all? Can confirm in next WG meeting about any general design for tab component.

@abautist
Copy link
Collaborator Author

abautist commented Dec 6, 2018

The component is styled in PCLN's DS theme. Bare bones in that the only functionality is clicking the tab labels to change active tab and display active tab's content. Content can be composite components, so hopefully super flexible/customizable. I'll open a PR to solicit more feedback on the code.

Example designs:
screen shot 2018-12-06 at 3 41 07 pm

screen shot 2018-12-04 at 2 35 25 pm

@jxnblk jxnblk mentioned this issue Dec 14, 2018
2 tasks
@James300 James300 added the v3 label Nov 15, 2019
@James300 James300 changed the title Bare bones tab component New Component: Tabs Nov 15, 2019
@craigpalermo craigpalermo added new component Proposal for new component and removed v3 labels Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new component Proposal for new component
Projects
None yet
Development

No branches or pull requests

4 participants