Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion : Make SKState descend from ScriptableObject? #11

Closed
darthbator opened this issue May 30, 2017 · 2 comments
Closed

Suggestion : Make SKState descend from ScriptableObject? #11

darthbator opened this issue May 30, 2017 · 2 comments

Comments

@darthbator
Copy link

Just wondering is there a reason that the base SKState class does not descend from scriptable object? I tend to make this change anytime I implement this repo (so that I can serialize and drag and drop states inside unity). Has this ever been considered? I just wanted to bring it up somewhere before sending a pull request for it.

@prime31
Copy link
Owner

prime31 commented May 30, 2017

I personally always prefer to use the highest class up the chain (object in this case). ScriptableObject is a much heavier beast. If you prefer ScriptableObjects it should be as simple as just adding them as a base class just one time when you import StateKit into your project and you're all set.

@darthbator
Copy link
Author

Cool deal! Just wanted to know if it's something you had thought about. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants