Dynamic Dialog: Fixed errors when is opened

[SoyDiego]

Fix #13497

Changed the changeDetection to onPush solves the problem. I don't know if it's the best solution. If you have another, let me know.

Note: Ignore the warning message responsive property is deprecated as table is always responsive with scrollable behavior.

CURRENT BEHAVIOUR

AFTER SOLUTION

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
primeng	⬜️ Ignored (Inspect)	Visit Preview		Aug 15, 2023 4:49pm

[MarcinBorowski95]

I'm not sure if changing the change detection is the best solution here. It could bring some unforeseen consequences.
Wouldn't it be better to:
Instead of using a method like this
[attr.aria-labelledby]="getAriaLabelledBy()"
create a property that will be initialized in a constructor/onInit?
That way change detection will not cause a refresh of labelledBy and then an error.

[SoyDiego]

I'm not sure if changing the change detection is the best solution here. It could bring some unforeseen consequences. Wouldn't it be better to: Instead of using a method like this [attr.aria-labelledby]="getAriaLabelledBy()" create a property that will be initialized in a constructor/onInit? That way change detection will not cause a refresh of labelledBy and then an error.

Thanks for check @MarcinBorowski95. In the issue post I said I don't know if it the best solution:

I will try your solution and generate a new PR if continue working good.
Thanks for review and comment a possible solution here!
This afternoon I will try to do it! :)

[SoyDiego]

Hi @MarcinBorowski95 I'm doing your way:

And it's true, works and no generate the error but now I have a doubt about this:

With your way we have same values on init and in the way of PrimeNG were different.

I don't know if it's correct or not but the error don't show like you said.

If I understood wrong, let me know and thanks again

[MarcinBorowski95]

I think this is still better. And if different id's are necessary then I guess two values can be generated. It will still be more optimized and less prone to bad change detection issues.

[SoyDiego]

I think this is still better. And if different id's are necessary then I guess two values can be generated. It will still be more optimized and less prone to bad change detection issues.

Thanks again bro. I added '_title' to the second one, just in case need to be different

.

I will do the PR doing a mention to you :)

[MarcinBorowski95]

Happy to help 😁

[SoyDiego]

Happy to help 😁

Here you have the PR, I cannot mentioned directly but I wrote your profile.