Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accordion: updateActiveIndex does not actually update _activeIndex #15674

Closed
LoaderB0T opened this issue May 23, 2024 · 0 comments · Fixed by #15675
Closed

Accordion: updateActiveIndex does not actually update _activeIndex #15674

LoaderB0T opened this issue May 23, 2024 · 0 comments · Fixed by #15675
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.18.0

Comments

@LoaderB0T
Copy link
Contributor

Describe the bug

When manually opening or closing an Accordion, the internal state of the component does not get updated correctly. _activeIndex still holds the old values.

This leads to issues when the control gets rendered and the expands/collapses by the user are ignored (in my case the sure can drag and drop accordions to sort them, which leads to re-rendering of the tabs).

Environment

Reproducer

No response

Angular version

17.3.0

PrimeNG version

17.17.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v20.11.1

Browser(s)

No response

Steps to reproduce the behavior

If required, I can try to build a repro scenario as the app this is happening in is closed source. However, the fix seems pretty straightforward and a PR will be opened shortly :)

Expected behavior

No response
@LoaderB0T LoaderB0T added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 23, 2024
@LoaderB0T LoaderB0T mentioned this issue May 23, 2024
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 30, 2024
@cetincakiroglu cetincakiroglu added this to the 17.18.0 milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.18.0
Development

Successfully merging a pull request may close this issue.

fix(accordion): updateActiveIndex does not update _activeIndex LoaderB0T/primeng
2 participants
@LoaderB0T @cetincakiroglu