Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfirmDialog: Unexpected re-rendering issue #3638

Closed
habubey opened this issue Nov 14, 2022 · 1 comment · Fixed by #3639
Closed

ConfirmDialog: Unexpected re-rendering issue #3638

habubey opened this issue Nov 14, 2022 · 1 comment · Fixed by #3639
Assignees
@melloware @ulasturann @habubey
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone
8.7.3

Comments

@habubey
Copy link
Contributor

habubey commented Nov 14, 2022

Describe the bug

ConfirmDialog component ( new-gen documentation page) while clicking the confirm dialog buttons the page renders multiple times.

Reproducer

No response

PrimeReact version

8.7.2

React version

18.x

Language

ALL

Build / Runtime

Next.js

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@habubey habubey added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 14, 2022
@melloware
Copy link
Member

I think its because they all get rendered as part of 1 page index.js but you have included <ConfirmDialog /> on each segment so its rendering 3 times. I think you only need <ConfirmDialog /> on the page once.

@melloware melloware self-assigned this Nov 14, 2022
@melloware melloware added this to the 8.7.3 milestone Nov 14, 2022
@melloware melloware added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 14, 2022
@melloware melloware mentioned this issue Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

@ulasturann ulasturann

@habubey habubey

Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Milestone
8.7.3
Development

Successfully merging a pull request may close this issue.

Fix #3638: ConfirmDialog showcase example render correctly melloware/primereact
3 participants
@melloware @ulasturann @habubey